Re: [PATCH bpf-next v1] selftests/bpf: remove enum64 case from __arg_untrusted test suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 8, 2025 at 3:09 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> The enum64 type used by verifier_global_ptr_args test case requires
> CONFIG_SCHED_CLASS_EXT. At the moment selftets do not depend on this
> option. There are just a few enum64 types in the kernel. Instead of
> tying selftests to implementation details of unrelated sub-systems,
> just remove enum64 test case. Simple enums are covered and that should
> be sufficient.

Can confirm that selftests now compile without the issue.

Tested-by: Amery Hung <ameryhung@xxxxxxxxx>

>
> Fixes: 68cca81fd57 ("selftests/bpf: tests for __arg_untrusted void * global func params")
> Reported-by: Amery Hung <ameryhung@xxxxxxxxx>
> Signed-off-by: Eduard Zingerman <eddyz87@xxxxxxxxx>
> ---
>  .../selftests/bpf/progs/verifier_global_ptr_args.c        | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/verifier_global_ptr_args.c b/tools/testing/selftests/bpf/progs/verifier_global_ptr_args.c
> index b346f669d159..181da86ba5f0 100644
> --- a/tools/testing/selftests/bpf/progs/verifier_global_ptr_args.c
> +++ b/tools/testing/selftests/bpf/progs/verifier_global_ptr_args.c
> @@ -275,11 +275,6 @@ __weak int subprog_enum_untrusted(enum bpf_attach_type *p __arg_untrusted)
>         return *(int *)p;
>  }
>
> -__weak int subprog_enum64_untrusted(enum scx_public_consts *p __arg_untrusted)
> -{
> -       return *(int *)p;
> -}
> -
>  SEC("tp_btf/sys_enter")
>  __success
>  __log_level(2)
> @@ -306,10 +301,9 @@ int anything_to_untrusted_mem(void *ctx)
>         subprog_void_untrusted((void *)mem + off);
>         /* variable offset to untrusted mem (trusted) */
>         subprog_void_untrusted(bpf_get_current_task_btf() + off);
> -       /* variable offset to untrusted char/enum/enum64 (map) */
> +       /* variable offset to untrusted char/enum (map) */
>         subprog_char_untrusted(mem + off);
>         subprog_enum_untrusted((void *)mem + off);
> -       subprog_enum64_untrusted((void *)mem + off);
>         return 0;
>  }
>
> --
> 2.47.1
>





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux