On Mon, Jun 30, 2025 at 8:25 PM Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> wrote: > > On Mon, Jun 30, 2025 at 08:07:01PM +0800, Jason Xing wrote: > > On Mon, Jun 30, 2025 at 7:47 PM Maciej Fijalkowski > > <maciej.fijalkowski@xxxxxxxxx> wrote: > > > > > > On Sun, Jun 29, 2025 at 06:43:05PM +0800, Jason Xing wrote: > > > > On Sun, Jun 29, 2025 at 10:51 AM Jason Xing <kerneljasonxing@xxxxxxxxx> wrote: > > > > > > > > > > On Fri, Jun 27, 2025 at 7:01 PM Jason Xing <kerneljasonxing@xxxxxxxxx> wrote: > > > > > > > > > > > > From: Jason Xing <kernelxing@xxxxxxxxxxx> > > > > > > > > > > > > This patch provides a setsockopt method to let applications leverage to > > > > > > adjust how many descs to be handled at most in one send syscall. It > > > > > > mitigates the situation where the default value (32) that is too small > > > > > > leads to higher frequency of triggering send syscall. > > > > > > > > > > > > Considering the prosperity/complexity the applications have, there is no > > > > > > absolutely ideal suggestion fitting all cases. So keep 32 as its default > > > > > > value like before. > > > > > > > > > > > > The patch does the following things: > > > > > > - Add XDP_MAX_TX_BUDGET socket option. > > > > > > - Convert TX_BATCH_SIZE to tx_budget_spent. > > > > > > - Set tx_budget_spent to 32 by default in the initialization phase as a > > > > > > per-socket granular control. 32 is also the min value for > > > > > > tx_budget_spent. > > > > > > - Set the range of tx_budget_spent as [32, xs->tx->nentries]. > > > > > > > > > > > > The idea behind this comes out of real workloads in production. We use a > > > > > > user-level stack with xsk support to accelerate sending packets and > > > > > > minimize triggering syscalls. When the packets are aggregated, it's not > > > > > > hard to hit the upper bound (namely, 32). The moment user-space stack > > > > > > fetches the -EAGAIN error number passed from sendto(), it will loop to try > > > > > > again until all the expected descs from tx ring are sent out to the driver. > > > > > > Enlarging the XDP_MAX_TX_BUDGET value contributes to less frequency of > > > > > > sendto() and higher throughput/PPS. > > > > > > > > > > > > Here is what I did in production, along with some numbers as follows: > > > > > > For one application I saw lately, I suggested using 128 as max_tx_budget > > > > > > because I saw two limitations without changing any default configuration: > > > > > > 1) XDP_MAX_TX_BUDGET, 2) socket sndbuf which is 212992 decided by > > > > > > net.core.wmem_default. As to XDP_MAX_TX_BUDGET, the scenario behind > > > > > > this was I counted how many descs are transmitted to the driver at one > > > > > > time of sendto() based on [1] patch and then I calculated the > > > > > > possibility of hitting the upper bound. Finally I chose 128 as a > > > > > > suitable value because 1) it covers most of the cases, 2) a higher > > > > > > number would not bring evident results. After twisting the parameters, > > > > > > a stable improvement of around 4% for both PPS and throughput and less > > > > > > resources consumption were found to be observed by strace -c -p xxx: > > > > > > 1) %time was decreased by 7.8% > > > > > > 2) error counter was decreased from 18367 to 572 > > > > > > > > > > More interesting numbers are arriving here as I run some benchmarks > > > > > from xdp-project/bpf-examples/AF_XDP-example/ in my VM. > > > > > > > > > > Running "sudo taskset -c 2 ./xdpsock -i eth0 -q 1 -l -N -t -b 256" > > > > > > do you have a patch against xdpsock that does setsockopt you're > > > introducing here? > > > > Sure, I added the following code in the apply_setsockopt(): > > if (setsockopt(xsk_socket__fd(xsk->xsk), SOL_XDP, 9, &a, sizeof(a)) < 0) > > ... > > > > > > > > -B -b 256 was for enabling busy polling and giving it 256 budget, which is > > > not what you wanted to achieve. > > > > I checked that I can use getsockopt to get the budget value the same > > as what I use setsockopt(). > > > > Sorry, I don't know what you meant here. Could you say more about it? > > I meant that -b is for setting SO_BUSY_POLL_BUDGET. just pick different > knob for your use case. After taking a deep sleep, I clearly know what that is... I will try to test with other parameters. But for me, the primary factor is the security interception on the host side because of a larger number of descs containing useless information. Well, I will find a good way to avoid this in the future... And what is your opinion of the current patch? I used [32, nentries] as the min/max range as you advised :) Thanks, Jason
