Re: [PATCH bpf-next] selftests/bpf: improve error messages in veristat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-06-27 at 21:01 +0100, Mykyta Yatsenko wrote:

[...]

> > > @@ -1955,6 +1967,8 @@ static int adjust_var_secinfo(struct btf *btf, const struct btf_type *t,
> > >   			break;
> > >   		case FIELD_NAME:
> > >   			err = adjust_var_secinfo_member(btf, base_type, 0, atom->name, sinfo);
> > > +			if (err == -ESRCH)
> > > +				fprintf(stderr, "Can't find '%s'\n", atom->name);
> > Nit: adjust_var_secinfo_member() already reports a few errors,
> >       maybe report this error there as well?

> That was my first attempt, but adjust_var_secinfo_member is called 
> recursively for anonymous embedded structures, so this particular error 
> will be noisy, as it'll get triggered for every embedded structure. 
> Placing error msg here makes sure it's printed just once and only in 
> cases when member is not present anywhere.

Makes sense, thank you for explaining.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux