On Thu, 26 Jun 2025 15:07:05 +0200 Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > FWIW, I recently found we have a second 'copy' of all this in > insn_get_seg_base() / get_desc(). > > Its all subtly different, but largely the same. Should I just use that then? Instead of: cs_base = segment_base_address(regs->cs); ss_base = segment_base_address(regs->ss); Use: cs_base = insn_get_seg_base(regs, INAT_SEG_REG_CS); ss_base = insn_get_seg_base(regs, INAT_SEG_REG_SS); As it is used in a few places in the x86 code already. Then I could get rid of this patch. -- Steve
