On Tue, 2025-06-24 at 17:21 -0700, Alexei Starovoitov wrote: [...] > I mean to add " = 123," to actual features, so when they're > backported the number stays the same. > Not to __MAX_BPF_FEAT. > > I doubt it matters though, > since bpf progs suppose to use > bpf_core_enum_value_exists(enum bpf_features, name) > that doesn't care about the actual id. > > In bpf helpers we got burned by broken backports and added > constants to ___BPF_FUNC_MAPPER macro. > Here I don't see it ever matter. > Just like I don't think __MAX_BPF_FEAT is needed, > but if we follow old steps, then let's do both __MAX_BPF_FEAT > without number and every feature with the number. > The end result will look like bpf_link_type. Understood, thank you, will respin.
