On Wed, 2025-06-18 at 21:39 +0100, Mykyta Yatsenko wrote:
> From: Mykyta Yatsenko <yatsenko@xxxxxxxx>
>
> Modify existing veristat tests to verify that array presets are applied
> as expected.
> Introduce few negative tests as well to check that common error modes
> are handled.
>
> Signed-off-by: Mykyta Yatsenko <yatsenko@xxxxxxxx>
> ---
Acked-by: Eduard Zingerman <eddyz87@xxxxxxxxx>
> .../selftests/bpf/prog_tests/test_veristat.c | 127 +++++++++++++++++-
> .../selftests/bpf/progs/set_global_vars.c | 56 +++++---
> 2 files changed, 159 insertions(+), 24 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/test_veristat.c b/tools/testing/selftests/bpf/prog_tests/test_veristat.c
> index 47b56c258f3f..f4de22302083 100644
> --- a/tools/testing/selftests/bpf/prog_tests/test_veristat.c
> +++ b/tools/testing/selftests/bpf/prog_tests/test_veristat.c
> @@ -60,13 +60,19 @@ static void test_set_global_vars_succeeds(void)
> " -G \"var_s8 = -128\" "\
> " -G \"var_u8 = 255\" "\
> " -G \"var_ea = EA2\" "\
> - " -G \"var_eb = EB2\" "\
> - " -G \"var_ec = EC2\" "\
> + " -G \"var_eb = EB2\" "\
> + " -G \"var_ec=EC2\" "\
Nit: white space is allowed for '=' but is not allowed for array
indexing, e.g. 'a[ 2]=1' or 'a [2]'.
> " -G \"var_b = 1\" "\
> - " -G \"struct1.struct2.u.var_u8 = 170\" "\
> + " -G \"struct1[2].struct2[1][2].u.var_u8[2]=170\" "\
> " -G \"union1.struct3.var_u8_l = 0xaa\" "\
> " -G \"union1.struct3.var_u8_h = 0xaa\" "\
> - "-vl2 > %s", fix->veristat, fix->tmpfile);
> + " -G \"arr[3]= 171\" " \
> + " -G \"arr[EA2] =172\" " \
> + " -G \"enum_arr[EC2]=EA3\" " \
> + " -G \"three_d[31][7][EA2]=173\"" \
> + " -G \"struct1[2].struct2[1][2].u.mat[5][3]=174\" " \
> + " -G \"struct11[7][5].struct2[0][1].u.mat[3][0] = 175\" " \
> + " -vl2 > %s", fix->veristat, fix->tmpfile);
>
> read(fix->fd, fix->output, fix->sz);
> __CHECK_STR("_w=0xf000000000000001 ", "var_s64 = 0xf000000000000001");
[...]
