On Wed, Jun 18, 2025 at 11:09 PM Stanislav Fomichev <stfomichev@xxxxxxxxx> wrote: > > On 06/18, Jason Xing wrote: > > From: Jason Xing <kernelxing@xxxxxxxxxxx> > > > > For some applications, it's quite useful to let users have the chance to > > tune the max budget, like accelerating transmission, when xsk is sending > > packets. Exposing such a knob also helps auto/AI tuning in the long run. > > > > The patch unifies two definitions into one that is 32 by default and > > makes the sysctl knob namespecified. > > > > Signed-off-by: Jason Xing <kernelxing@xxxxxxxxxxx> > > --- > > v2 > > Link: https://lore.kernel.org/all/20250617002236.30557-1-kerneljasonxing@xxxxxxxxx/ > > 1. use a per-netns sysctl knob > > Why are you still insisting on the sysctl? Why not a per-socket (struct > xdp_sock) value? And then you can add a setsockopt (xsk_setsockopt) to tune it. Oh, I gave that thought too. At that time, I was thinking it requires an extra system call to take effect. Maybe not that flexible? I'll follow your advice in V3 if no other objections arise. Thanks, Jason
