Re: [RFC bpf-next 9/9] selftests/bpf: add selftests for indirect jumps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 15, 2025 at 1:55 AM Anton Protopopov
<a.s.protopopov@xxxxxxxxx> wrote:
> +SEC("syscall")
> +int two_towers(struct simple_ctx *ctx)
> +{
> +       switch (ctx->x) {
>

Not sure why you went with switch() statements everywhere.
Please add few tests with explicit indirect goto
like interpreter does: goto *jumptable[insn->code];

Remove all bpf_printk() too and get easy on names.
i_am_a_little_tiny_foo() sounds funny today, but
it won't be funny at all tomorrow.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux