On 6/10/25 10:12 PM, Toke Høiland-Jørgensen wrote:
Daniel Borkmann <daniel@xxxxxxxxxxxxx> writes:
[...]
Also, have you thought about taking the opportunity to generalize the existing struct xsk_tx_metadata? It would be nice to actually use the same/similar struct for RX and TX, similarly as done in struct virtio_net_hdr. Such that we have XDP_{RX,TX}_METADATA and XDP_{RX,TX}MD_FLAGS_* to describe what meta data we have and from a developer PoV this will be a nicely consistent API in XDP. Then you could store at the right location in the meta data region just with bpf_xdp_metadata_* kfuncs (and/or plain BPF code) and finally set XDP_RX_METADATA indicator bit.Wouldn't this make the whole thing (effectively) UAPI?
I'm not sure I follow, we already have this in place for the meta data region in AF_XDP, this would extend the scope to RX as well, so there would be a similar 'look and feel' in that sense it is already a developer API which is used. Cheers, Daniel
