On Thu, 2025-06-12 at 15:31 -0700, Eduard Zingerman wrote:
> On Thu, 2025-06-12 at 15:11 -0700, Song Liu wrote:
> > With input changed == NULL, a local variable is used for "changed".
> > Initialize tmp properly, so that it can be used in the following:
> > *changed |= err > 0;
> >
> > Otherwise, UBSAN will complain:
> >
> > UBSAN: invalid-load in kernel/bpf/verifier.c:18924:4
> > load of value <some random value> is not a valid value for type '_Bool'
> >
> > Fixes: 6b3f95cd99f8 ("bpf: set 'changed' status if propagate_liveness() did any updates")
> > Signed-off-by: Song Liu <song@xxxxxxxxxx>
> > ---
>
> Should add UBSAN to my config, sorry.
> There is also a `tmp` in __mark_chain_precision, unitialized as well.
> Could you please re-send v2 with both fixed?
Nevermind, in __mark_chain_precision it is only written to.
Acked-by: Eduard Zingerman <eddyz87@xxxxxxxxx>
