Steven Rostedt <rostedt@xxxxxxxxxxx> writes: > From: Steven Rostedt <rostedt@xxxxxxxxxxx> > > Each TRACE_EVENT() defined can take up around 5K of text and meta data > regardless if they are used or not. New code is being developed that will > warn when a tracepoint is defined but not used. > > The trace events xdp_redirect_map and xdp_redirect_map_err are defined but > not used, but there's also a comment that states these are kept around for > backward compatibility. Which is interesting because since they are not > used, any old BPF program that expects them to exist will get incorrect > data (no data) when they use them. It's worse than not working, it's > silently failing. > > Remove them as they will soon cause warnings, or if they really need to > stick around, then code needs to be added to use them. > > Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx> I guess that makes sense; I have no objections to getting rid of them. Reviewed-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
