Re: [PATCH bpf-next v2 09/11] libbpf: Introduce bpf_prog_stream_read() API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 May 2025 at 20:02, Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> writes:
>
> > Introduce a libbpf API so that users can read data from a given BPF
> > stream for a BPF prog fd. For now, only the low-level syscall wrapper
> > is provided, we can add a bpf_program__* accessor as a follow up if
> > needed.
> >
> > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx>
> > ---
>
> Acked-by: Eduard Zingerman <eddyz87@xxxxxxxxx>
>
> [...]
>
> > +int bpf_prog_stream_read(int prog_fd, __u32 stream_id, void *stream_buf, __u32 stream_buf_len)
>
> Note: many of such utility functions have _opts parameter for future
>       extensibility. Imo in this case it would hinder usability a bit.
>       If need be bpf_prog_stream_read_opts can be added later.
>

We may have more arguments in the future (like count of errors, as
Alan requested), so it may be a good idea to add the opts variant
directly now.

> [...]




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux