On Wed, 28 May 2025 16:57:15 +0200 Alexander Lobakin wrote:
> > On Tue, 20 May 2025 13:59:04 -0700 Tony Nguyen wrote:
> >> + if (sinfo || !netmem_is_net_iov(netmem)) {
> >> + const struct page_pool *pp = __netmem_get_pp(netmem);
> >> +
> >> + dma_sync_single_for_device(pp->p.dev, desc.addr, desc.len,
> >> + DMA_BIDIRECTIONAL);
> >> + }
> >
> > How can we get an unreadable netmem into the XDP Tx path?
>
> For now, it's not allowed. This is future proof. I have plans to allow
> XDP and devmem to co-exist when the XDP program doesn't want to access
> frags, only headers. In that case, why forbid?
Nonsensical code is harder to maintain. Someone may need to refactor
this later and waste time trying to figure out why the condition is
there.
Plus in patch 1 you remove legit conditions to save branches and here
you seem to happily sprinkle dead code.
