On Tue, May 27, 2025 at 7:29 PM Byungchul Park <byungchul@xxxxxx> wrote: > > Use netmem put API, put_netmem(), instead of put_page() in > page_pool_return_netmem(). > > While at it, delete #include <linux/mm.h> since the last put_page() in > page_pool.c has been just removed with this patch. > > Signed-off-by: Byungchul Park <byungchul@xxxxxx> > --- > net/core/page_pool.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 8d52363f37cc..fb487013ef00 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -20,7 +20,6 @@ > #include <linux/dma-direction.h> > #include <linux/dma-mapping.h> > #include <linux/page-flags.h> > -#include <linux/mm.h> /* for put_page() */ > #include <linux/poison.h> > #include <linux/ethtool.h> > #include <linux/netdevice.h> > @@ -712,7 +711,7 @@ static __always_inline void __page_pool_release_page_dma(struct page_pool *pool, > /* Disconnects a page (from a page_pool). API users can have a need > * to disconnect a page (from a page_pool), to allow it to be used as > * a regular page (that will eventually be returned to the normal > - * page-allocator via put_page). > + * page-allocator via put_netmem() and then put_page()). nit: I think the "and then put_page()" is not needed. Reviewed-by: Mina Almasry <almasrymina@xxxxxxxxxx> -- Thanks, Mina
