Re: [PATCH bpf-next v4 1/4] bpf: Teach vefier to handle const ptrs as args to kfuncs

[Matt Bobrowski <mattbobrowski@xxxxxxxxxx>]

On Fri, May 09, 2025 at 09:20:53AM -0700, Alexei Starovoitov wrote:
> On Thu, May 8, 2025 at 2:09 AM Matt Bobrowski <mattbobrowski@xxxxxxxxxx> wrote:
> >
> > >
> > >  static int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg,
> > > -                      u32 regno, u32 mem_size)
> > > +                      u32 regno, u32 mem_size, bool read_only)
> >
> > Maybe s/read_only/write_mem_access?
> 
> 'bool' arguments are not readable at the callsite.
> Let's use enum bpf_access_type BPF_READ|WRITE here
> or introduce another enum ?

Yes, I agree, and using enum bpf_access_type is also something that
had crossed my mind. I think that's what should be used here in favour
of the boolean.