Re: [PATCH bpf-next] bpf: Always WARN_ONCE on verifier bugs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 8, 2025 at 1:40 PM Paul Chaignon <paul.chaignon@xxxxxxxxx> wrote:
>
> Throughout the verifier's logic, there are multiple checks for
> inconsistent states that should never happen and would indicate a
> verifier bug. These bugs are typically logged in the verifier logs and
> sometimes preceded by a WARN_ONCE.
>
> This patch reworks these checks to consistently emit a verifier log AND
> a warning. The consistent use of WARN_ONCE should help fuzzers (ex.
> syzkaller) expose any situation where they are actually able to reach
> one of those buggy verifier states.

No. We cannot do it.
WARN_ONCE is for kernel level issues.
In some configs use panic_on_warn=1 too.
Whereas a verifier bug is contained within a verifier.
It will not bring the kernel down.
We should remove most of the existing WARN_ONCE instead.
Potentially replace them with pr_info_once().

pw-bot: cr





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux