Re: [PATCH v3 3/3] exec: Add support for 64 byte 'tsk->real_comm'

[Bhupesh Sharma <bhsharma@xxxxxxxxxx>]

On 5/7/25 10:53 PM, Steven Rostedt wrote:
> On Wed, 7 May 2025 14:54:36 +0200
> Petr Mladek <pmladek@xxxxxxxx> wrote:
>
> > > To fix the same, Linus suggested in [1] that we can add the
> > > following union inside 'task_struct':
> > >         union {
> > >                 char    comm[TASK_COMM_LEN];
> > >                 char    real_comm[REAL_TASK_COMM_LEN];
> > >         };
> > Nit: IMHO, the prefix "real_" is misleading. The buffer size is still
> >        limited and the name might be shrinked. I would suggest
> Agreed.
>
> >        something like:
> >
> > 	char    comm_ext[TASK_COMM_EXT_LEN];
> > or
> > 	char    comm_64[TASK_COMM_64_LEN]
> I prefer "comm_ext" as I don't think we want to hard code the actual size.
> Who knows, in the future we may extend it again!

Ok, let me use 'comm_64' instead in v4.

Thanks for the review.

Regards,
Bhupesh