Re: [PATCH v6 bpf-next 7/7] selftests/bpf: Add tests for bucket resume logic in UDP socket iterators

[Martin KaFai Lau <martin.lau@xxxxxxxxx>]

On 4/28/25 11:00 AM, Jordan Rife wrote:
> +static void do_resume_test(struct test_case *tc)
> +{
> +	static const __u16 port = 10001;
> +	struct bpf_link *link = NULL;
> +	struct sock_iter_batch *skel;
> +	struct sock_count *counts;
> +	int err, iter_fd = -1;
> +	const char *addr;
> +	int local_port;
> +	int *fds;
> +
> +	counts = calloc(tc->max_socks, sizeof(*counts));
> +	if (!counts)

ASSERT_OK_PTR.

Overall lgtm. In addition to avoiding the skip/repeat, the code is also simpler 
(e.g. the st_bucket_done and offset state are gone). Thanks.

> +		return;