> > @@ -69,6 +70,21 @@ static int dwxgmac2_get_tx_ls(struct dma_desc *p) > > return (le32_to_cpu(p->des3) & XGMAC_RDES3_LD) > 0; } > > > > +static u16 dwxgmac2_wrback_get_rx_vlan_tci(struct dma_desc *p) { > > + return (le32_to_cpu(p->des0) & XGMAC_RDES0_VLAN_TAG_MASK); > > nit: The outer parentheses are not needed on the line above. > > return le32_to_cpu(p->des0) & XGMAC_RDES0_VLAN_TAG_MASK; > > Hi Simon, thanks for the comment, will update in v5. Regards, Boon Khai