> > This patch does IMHO too many things together, and should be split in several > ones, i.e.: > - just moving the code in a separate file > - rename functions and simbols. > - other random changes... > Hi Paolo, Thanks for the comment, sure, will divide this rework into two patches with 1) just moving the code in a separate file 2) rename functions and symbols - will not include random changes, will explain on that below. > > + > > + netdev_err(dev, "Timeout accessing MAC_VLAN_Tag_Filter\n"); > > + > > + return -EBUSY; > > ... like the above on (which looks unnecessary?!?) > These changes were not intended. Last year when I was porting from dwmac4 to stmmac_vlan.c, I was unaware of new changes in the VLAN function. I relied too heavily on Git to alert me to conflicting Changes on the updated function. Little did I know that when I removed code from dwmac4, I will cross-check the latest changes and submit them again in v5, together with the separated commit. Regards, Boon Khai.
