Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> writes: [...] > diff --git a/tools/testing/selftests/bpf/progs/stream_bpftool.c b/tools/testing/selftests/bpf/progs/stream_bpftool.c > new file mode 100644 > index 000000000000..438c01a96efc > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/stream_bpftool.c This file is almost identical to ./tools/bpf/bpftool/skeleton/stream.bpf.c except it also adds a function `foo` that exhausts may goto budget, as far as I can tell. What is the point of adding it? In general, I don't think we run bpftool tests on the CI, so it would be good to test stream.bpf.c itself e.g. by creating a symlink to it in selftests and adding a corresponding prog_tests/<smth>.c as you do here. Also, it would be good if some of the tests checked the content read from the stream. I think existing tests only check the size. [...]
