Re: [PATCH] selftests/bpf: close the file descriptor to avoid resource leaks

[Martin KaFai Lau <martin.lau@xxxxxxxxx>]

On 4/12/25 11:38 AM, Malaya Kumar Rout wrote:
> diff --git a/tools/testing/selftests/bpf/prog_tests/sk_assign.c b/tools/testing/selftests/bpf/prog_tests/sk_assign.c
> index 0b9bd1d6f7cc..05cf66265cf1 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sk_assign.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sk_assign.c
> @@ -37,8 +37,10 @@ configure_stack(void)
>   	tc = popen("tc -V", "r");
>   	if (CHECK_FAIL(!tc))
>   		return false;
> -	if (CHECK_FAIL(!fgets(tc_version, sizeof(tc_version), tc)))
> +	if (CHECK_FAIL(!fgets(tc_version, sizeof(tc_version), tc))) {
> +		close(tc);

It is not even compiler tested.

pw-bot: cr

>   		return false;
> +	}
>   	if (strstr(tc_version, ", libbpf "))
>   		prog = "test_sk_assign_libbpf.bpf.o";
>   	else