On 4/4/25 16:19, Sebastian Sewior wrote:
Alexei, thank you for the Cc.
On 2025-04-03 13:35:10 [-0700], Alexei Starovoitov wrote:
Stating the obvious...
Sebastian did a lot of work removing preempt_disable from the networking
stack.
We're certainly not adding them back.
This patch is no go.
While looking through the code, it looks as if lwtunnel_xmit() lacks a
local_bh_disable().
Thanks Sebastian for the confirmation, as the initial idea was to use
local_bh_disable() as well. Then I thought preempt_disable() would be
enough in this context, but I didn't realize you made efforts to remove
it from the networking stack.
@Alexei, just to clarify: would you ACK this patch if we do
s/preempt_{disable|enable}()/local_bh_{disable|enable}()/g ?
Sebastian
