On 3/25/25 2:59 AM, Alan Maguire wrote: > > [...] > > Great; so let's do this to land the series. Could you either > > - check I merged your patches correctly in the above branch, and if they > look good I'll merge them into next and I'll officially send the feature > check patch; or if you'd prefer > - send a v5 (perhaps including my feature check patch?) > > ...whichever approach is easiest for you. Hi Alan. I reviewed the diff between your branch: https://web.git.kernel.org/pub/scm/devel/pahole/pahole.git/log/?h=next.attributes-v4 and v1.29 + my patchset: https://github.com/theihor/dwarves/tree/v4.kf-arena Not a lot of difference besides your patch. Didn't spot any problems. I also ran a couple of tests on your branch: * generate BTF with and without --btf_feature=attributes * run ./tests/tests on 6.14-rc3 vmlinux (just a build I had at hand) I think you can apply patches from next.attributes-v4 as is. Thank you. > > Thanks! > > Alan