Re: [PATCH v3 00/12] man2: document "new" mount API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2025-08-17, Askar Safin <safinaskar@xxxxxxxxxxxx> wrote:
> I just sent to fsdevel fix for that RESOLVE_NO_XDEV bug.

Thanks, I've sent some review comments.

> 	if (!(lookup_flags & (LOOKUP_PARENT | LOOKUP_DIRECTORY |
> 			   LOOKUP_OPEN | LOOKUP_CREATE | LOOKUP_AUTOMOUNT)) &&
> 
> We never return -EISDIR in this "if" if we are in non-final component
> thanks to LOOKUP_PARENT here. We fall to finish_automount instead.

Grr, I re-read this conditional a few times and I still misunderstood
what it was doing. My bad.

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux