> -----Original Message----- > From: Takashi Iwai <tiwai@xxxxxxx> > Sent: Thursday, August 21, 2025 3:17 PM > To: Ding, Shenghao <shenghao-ding@xxxxxx> > Cc: broonie@xxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; > 13564923607@xxxxxxx; 13916275206@xxxxxxx; alsa-devel@alsa- > project.org; linux-kernel@xxxxxxxxxxxxxxx; Xu, Baojun <baojun.xu@xxxxxx>; > Baojun.Xu@xxxxxxx; Ji, Jesse <jesse-ji@xxxxxx> > Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Enable > init_profile_id for device initialization > > On Wed, 20 Aug 2025 10: 21: 23 +0200, Shenghao Ding wrote: > > Optimize > the time consumption of profile switching, init_profile saves > the common > settings of different profiles, such as the dsp coefficients, > etc, which can > greatly ZjQcmQRYFpfptBannerStart This message was sent from outside of > Texas Instruments. > Do not click links or open attachments unless you recognize the source of > this email and know the content is safe. > <https://us-phishalarm- > ewt.proofpoint.com/EWT/v1/G3vK!vxdrHf3mV2Ub4obsvxtoX4FTV-yYd_C- > 6ngQtFeUFpCRaEESj8_B-sZXmuX5JN2I2u4Qx-lD$> > Report Suspicious > > ZjQcmQRYFpfptBannerEnd > On Wed, 20 Aug 2025 10:21:23 +0200, > Shenghao Ding wrote: > > > > Optimize the time consumption of profile switching, init_profile saves > > the common settings of different profiles, such as the dsp > > coefficients, etc, which can greatly reduce the profile switching time > > comsumption and remove the repetitive settings. > > .............................. > The patch causes build errors: > > sound/hda/codecs/side-codecs/tas2781_hda_i2c.c: In function > ʽtasdevice_dspfw_initʼ: > sound/hda/codecs/side-codecs/tas2781_hda_i2c.c:468:29: error: ʽstruct > tasdevice_rcaʼ has no member named ʽinit_profile_idʼ > 468 | if (tas_priv->rcabin.init_profile_id >= 0) > | ^ > .... > > Something still not landed in my tree yet. I will resubmit it after your tree is ready. > > > thanks, > > Takashi
