On Thu, Sep 11, 2025 at 05:21:14PM +0000, Holalu Yogendra, Niranjan wrote: > > From: Mark Brown <broonie@xxxxxxxxxx> > > Why is this a separate API, what is the situation where we would want to > > report an invalid value from a control? I was thinking of just adding > > this to the existing operations rather than adding separate ones that > > need to be explicitly set. > Since few of the drivers as still using the original API, and was not sure if > everyone wanted to clamp the register value, did not want to disturb the > original API snd_soc_get_volsw. Per my analysis, if register read fails due to In what situation would anything want to report an invalid value? > some issue (like IO) and, for some reason if register value was modified > to have the value greater than mc->max value, the volume is report erroneously. > Are you thinking that this patch could be dropped and clamp the value to max in > 'soc_get_volsw' (as in 1st patch) and use the same API ? Please suggest. Yes, everything should report valid values. I/O errors should be propagated as errors.
Attachment:
signature.asc
Description: PGP signature
