On Tue, Apr 08, 2025 at 10:45:22AM +0800, Shenghao Ding wrote: > Move the common macro definition of kcontrols into a common header. Makes sense. ... > +++ b/sound/pci/hda/tas2781_hda.h > +#ifndef __TAS2781_HDA_H__ > +#define __TAS2781_HDA_H__ It is better to follow IWYU principle, i.e. this header uses the following: + sound/asound.h -- With Best Regards, Andy Shevchenko