RE: [PATCH v3 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > 
> >>> +
> >>> +  prefix_name:
> >>
> >> No underscores in node names, missing vendor prefix... but more
> >> important:  I don't understand the need for this property. Description copies property name so it is not useful.
> 
> And these comments as well.

The prefix_name is used to distinguish the dapm and kcontrol of each individual codec.
And I will update name of the property 

> > 
> >>> +  everest,dmic-enabled:
> >>> +    $ref: /schemas/types.yaml#/definitions/flag
> >>> +    description:
> >>> +      The property is a choice between PDM and AMIC
> >>> +
> >>
> >> No supplies?
> > 
> > I will drop the property
> 
> I did not comment about dmic, but meant missing power supplies, which
> usually are placed here.

I apologize for misunderstanding your comment.
But we don't have properties about the power supplies



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux