Re: [PATCH] selftests/alsa: remove 0/NULL global variable assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Fri, Aug 22, 2025 at 01:57:05AM +0300, Nikola Z. Ivanov wrote:
> On Thu, Aug 21, 2025 at 10:30:50PM +0100, Mark Brown wrote:

> > Do you have a reference there, note that these are just plain non-static
> > variables?  I wouldn't trust checkpatch for anything that isn't kernel
> > code (and even there it's got issues).

> This is what it says in the C99/C11/C18/C23 drafts I found:

...

> Since as you said checkpatch.pl is mostly intended for kernel code
> (which I was not aware of) this patch is probably not desired.
> In case it still is I can add quote to the draft and link it in the patch.

No, it's fine - thanks for checking the reference.  I suspected this
might be something specific to how the kernel is linked:

Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux