Re: [PATCH] soundwire: bus: Drop dev_pm_domain_detach() call

[Ulf Hansson <ulf.hansson@xxxxxxxxxx>]

On Wed, 27 Aug 2025 at 12:15, Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
>
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Starting with commit f99508074e78 ("PM: domains: Detach on
> device_unbind_cleanup()"), there is no longer a need to call
> dev_pm_domain_detach() in the bus remove function. The
> device_unbind_cleanup() function now handles this to avoid
> invoking devres cleanup handlers while the PM domain is
> powered off, which could otherwise lead to failures as
> described in the above-mentioned commit.
>
> Drop the explicit dev_pm_domain_detach() call and rely instead
> on the flags passed to dev_pm_domain_attach() to power off the
> domain.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe


> ---
>  drivers/soundwire/bus_type.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
> index bc1e653080d9..91e70cb46fb5 100644
> --- a/drivers/soundwire/bus_type.c
> +++ b/drivers/soundwire/bus_type.c
> @@ -114,7 +114,6 @@ static int sdw_drv_probe(struct device *dev)
>
>         ret = drv->probe(slave, id);
>         if (ret) {
> -               dev_pm_domain_detach(dev, false);
>                 ida_free(&slave->bus->slave_ida, slave->index);
>                 return ret;
>         }
> @@ -180,8 +179,6 @@ static int sdw_drv_remove(struct device *dev)
>         if (drv->remove)
>                 ret = drv->remove(slave);
>
> -       dev_pm_domain_detach(dev, false);
> -
>         ida_free(&slave->bus->slave_ida, slave->index);
>
>         return ret;
> --
> 2.43.0
>