Re: [PATCH v2 3/3] ASoC: qcom: sc8280xp: Fix DAI format setting for MI2S interfaces

[Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>]

On 9/5/2025 4:16 PM, Konrad Dybcio wrote:
> On 9/5/25 12:40 PM, Mohammad Rafi Shaik wrote:
> > The current implementation does not configure the CPU DAI format for
> > MI2S interfaces, resulting in -EIO errors during audio playback and
> > capture. This prevents the correct clock from being enabled for the
> > MI2S interface. Configure the required DAI format to enable proper
> > clock settings. Tested on Lemans evk platform.
> >
> > Fixes: 295aeea6646ad ("ASoC: qcom: add machine driver for sc8280xp")
> > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> > ---
> >   sound/soc/qcom/sc8280xp.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> > index 73f9f82c4e25..2fd06354923a 100644
> > --- a/sound/soc/qcom/sc8280xp.c
> > +++ b/sound/soc/qcom/sc8280xp.c
> > @@ -32,6 +32,9 @@ static int sc8280xp_snd_init(struct snd_soc_pcm_runtime *rtd)
> >   	int dp_pcm_id = 0;
> >   
> >   	switch (cpu_dai->id) {
> > +	case PRIMARY_MI2S_RX...QUATERNARY_MI2S_TX:
>
> there's a discontiguous (i.e. asking for another 'case') QUINARY MI2S

Ack,

it can be handled with another case because discontinuous id's.

> there's also a SENARY MI2S, but that we don't define upstream today
yes.

As for SENARY_MI2S, since it's not defined upstream yet no need handle now.

Thanks & Regards,
Rafi.> Konrad