Re: [PATCH v2 1/2] ALSA: compress: add raw opus codec define and opus decoder structs

[Takashi Iwai <tiwai@xxxxxxx>]

On Wed, 10 Sep 2025 10:11:41 +0200,
Alexey Klimov wrote:
> +struct snd_dec_opus {
> +	union {
> +		struct {
> +			__u8 minor:4;
> +			__u8 major:4;
> +		} __attribute__((packed)) fields;

Bit fields aren't really good for ABI definition, as it's not well
defined.  I'd rather leave it as a u8.  If any, you can provide a
bitmask definition or a macro to retrieve the version numbers.

Also, don't forget to bump the API protocol number.
It's been already increased to 0.4.0 for 64bit tstamp support, and
yours need to increase one more.

(That is, please make sure to create patches based on linux-next, or
 for-next branch of sound git tree.)


thanks,

Takashi