Re: [PATCH v1 07/14] dt-bindings: display: mediatek,ufoe: Add mediatek,gce-client-reg property

["Ariel D'Alessandro" <ariel.dalessandro@xxxxxxxxxxxxx>]

Krzysztof,

On 8/21/25 3:50 AM, Krzysztof Kozlowski wrote:
> On Wed, Aug 20, 2025 at 02:12:55PM -0300, Ariel D'Alessandro wrote:
> > Current, the DT bindings for Mediatek UFOe (Unified Frame Optimization
> > engine) is missing the mediatek,gce-client-reg property. Add it and
>
> Why is it missing? If the binding is complete, it cannot be missing...

Due to the following error:

$ make -j$(nproc) CHECK_DTBS=y mediatek/mt8173-elm.dtb
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  DTC [C] arch/arm64/boot/dts/mediatek/mt8173-elm.dtb
[...]
arch/arm64/boot/dts/mediatek/mt8173-elm.dtb: ufoe@1401a000 
(mediatek,mt8173-disp-ufoe): 'mediatek,gce-client-reg' does not match 
any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: 
http://devicetree.org/schemas/display/mediatek/mediatek,ufoe.yaml#

> > update the example as well.
> >
> > Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@xxxxxxxxxxxxx>
> > ---
> >   .../bindings/display/mediatek/mediatek,ufoe.yaml      | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml
> > index 61a5e22effbf2..ecb4c0359fec3 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml
> > @@ -64,6 +64,14 @@ properties:
> >         - port@0
> >         - port@1
> >   
> > +  mediatek,gce-client-reg:
> > +    description: The register of client driver can be configured by gce with
> > +      4 arguments defined in this property, such as phandle of gce, subsys id,
> > +      register offset and size. Each GCE subsys id is mapping to a client
>
> Don't explain what DT syntax is. We all know, so that's completely
> redundant description. Explain the purpose. Explain Arguments with sechema - items.

Although I agree with your suggestions, this is exactly how the rest of 
the Mediatek DT bindings describe this node. This patch is based on the 
other +20 files, which describe the node in the same way.

Regards,

--
Ariel D'Alessandro
Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK 
Registered in England & Wales, no. 5513718