On 8/28/25 14:54, Stefan Kober wrote:
> This patchset adds the necessary functionality to support disk hotplugging in the CH driver.
>
> Some alias handling that can be extended to other device types is added, in order to allow detaching the devices via the Cloud Hypervisor API.
>
> Stefan Kober (13):
> ch: add DomainAttachDevice skeletons
> ch: add DomainDetachDevice skeletons
> ch: add ch_hotplug.{h,c} files to CH build
> ch: call into ch_hotplug implementation
> ch: pass disk alias to CHV
> ch: add ch_alias.{c,h} for device alias handling
> ch: add virCHMonitorPut function
> ch: use MonitorPut in MonitorPutNoContent
> ch: add disk attach functionality
> ch: assign aliases in ProcessPrepareDomain
> ch: Add virCHMonitorRemoveDevice function
> ch: implement disk device hot removal
> NEWS: announce disk hotplug support for ch
>
> NEWS.rst | 5 +
> po/POTFILES | 1 +
> src/ch/ch_alias.c | 59 ++++++++
> src/ch/ch_alias.h | 27 ++++
> src/ch/ch_driver.c | 86 ++++++++++++
> src/ch/ch_hotplug.c | 333 ++++++++++++++++++++++++++++++++++++++++++++
> src/ch/ch_hotplug.h | 33 +++++
> src/ch/ch_monitor.c | 81 +++++++++--
> src/ch/ch_monitor.h | 7 +
> src/ch/ch_process.c | 4 +
> src/ch/meson.build | 4 +
> 11 files changed, 630 insertions(+), 10 deletions(-)
> create mode 100644 src/ch/ch_alias.c
> create mode 100644 src/ch/ch_alias.h
> create mode 100644 src/ch/ch_hotplug.c
> create mode 100644 src/ch/ch_hotplug.h
>
I've taken closer look at these and in general they look good. I mean,
what Peter wrote still applies and needs to be addressed in v2, but
we're on a track here.
Michal
