On Mon, Sep 08, 2025 at 04:00:06PM -0600, Jim Fehlig wrote: > Hi Andrea, > > Is there anything I can do to help move this series forward? I think 8/10 > can now be considered for merging, correct? Well, yes, but I'm not particularly keen on updating libvirt's test suite when the status in the Fedora edk2 package is still in flux. Especially since I would like that specific change to ultimately be entirely reverted :) More on that below. > BTW, I'm fine with the patch order, based on your rational in 4/10 > > https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/message/PZEMOM474JUHWIIX3SOUITBHHTDBIVDN/ > > So my previous comments on patches 4 and 5 aren't really valid. Should I > re-review those? Yes please! All the patches that are not marked as DONOTMERGE are good to go as far as I'm concerned. > Were you planning to spin another version which includes > patch 8? Not necessarily, but I have just opened https://src.fedoraproject.org/rpms/edk2/pull-request/14 which contains all the changes that I believe are necessary when it comes to firmware descriptors. I can maybe post a respin that includes all those changes, just to show how things would look like if they landed. Would you find that useful? -- Andrea Bolognani / Red Hat / Virtualization
