Re: [PATCH v2 0/4] Some parsing functions refactor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/22/25 17:12, Kirill Shchetiniuk via Devel wrote:
> This patch series is supposed to refactor the existing logic of
> some parsing functions, changing the previous approach of getting
> the string fisrt and then parsing the string itself. Now the
> parsing logic is implemented by using the appropriate virXMLProp*
> functions.
> 
> Changelog fromm v1:
> 
> 1. 'ret' temp value is now 'rc'
> 2. code style fixes
> 3. 'id' param is now parsed as not mandatory
> 
> 
> Kirill Shchetiniuk (4):
>   conf: virNetDevVPortProfileParse refactor
>   util: virSecretLookupParseSecret refactor
>   conf: virDomainChrDefParseTargetXML refactor
>   qemu: qemuDomainObjPrivateXMLParseVcpu refactor
> 
>  src/conf/domain_conf.c               |  16 +---
>  src/conf/netdev_vport_profile_conf.c | 112 +++++++++++----------------
>  src/qemu/qemu_domain.c               |  16 +---
>  src/util/virsecret.c                 |  19 ++---
>  4 files changed, 55 insertions(+), 108 deletions(-)
> 
> --
> 2.49.0
> 

I'm fixing all the small nits I've raised and merging.

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux