Re: [PATCH] qemu_tpm: Do not use persistent definition during pre-start checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 18, 2025 at 03:08:38PM +0200, Martin Kletzander wrote:
> From: Martin Kletzander <mkletzan@xxxxxxxxxx>
> 
> Commit 3451987fca7c used the persistent TPM Definition in both calls to
> qemuTPMVirCommandSwtpmAddTPMState() but in one of the two cases it
> might've been NULL and what's more, it is not the right definition which
> should've been used.  Change that to @tpm which is the current
> definition.  The other call does not have access to the current
> definition and is only called during updating the profile.  But for the
> sake of fewer future mistakes, keep the other one as is because there is
> no issue with calling it that way and adding logic that just skips the
> extra check on NULL could mistake someone in the future.
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  src/qemu/qemu_tpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux