[PATCH] network: fix memory leak in networkAddFirewallRules()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Add g_clear_pointer() to networkAddFirewallRules()
after using virSetError() to free errInitV4 and errInitV6
to avoid memory leaks.

Fixes: ef760a4133 (Revert "network: support setting firewalld zone for bridge device of open networks")
Signed-off-by: Elizaveta Tereshkina <etereshkina@xxxxxxxxxxxxx>
---
 src/network/bridge_driver_linux.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c
index 86f6a5915f..93d4d2c8ee 100644
--- a/src/network/bridge_driver_linux.c
+++ b/src/network/bridge_driver_linux.c
@@ -413,6 +413,7 @@ networkAddFirewallRules(virNetworkDef *def,
             (virNetworkDefGetIPByIndex(def, AF_INET, 0) ||
              virNetworkDefGetRouteByIndex(def, AF_INET, 0))) {
             virSetError(errInitV4);
+            g_clear_pointer(&errInitV4, virFreeError);
             return -1;
         }
 
@@ -421,6 +422,7 @@ networkAddFirewallRules(virNetworkDef *def,
              virNetworkDefGetRouteByIndex(def, AF_INET6, 0) ||
              def->ipv6nogw)) {
             virSetError(errInitV6);
+            g_clear_pointer(&errInitV6, virFreeError);
             return -1;
         }
 
-- 
2.39.2



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux