Re: [PATCH 01/10] src: Unify argument name of virDomainMigratePrepare()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Thursday in 2025, Michal Privoznik via Devel wrote:
From: Michal Privoznik <mprivozn@xxxxxxxxxx>

The virDomainMigratePrepare() API declares its last argument as
'bandwidth', though throughout various typedefs, RPC and callback
implementations the name is changed to 'resource'. This creates a
confusing. Unify the name.

Did you just noun confusing?

The prescriptivist in me is screaming, but the other part of me
feels it's too funny to fix.


Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
src/driver-hypervisor.h             | 2 +-
src/esx/esx_driver.c                | 2 +-
src/libvirt_internal.h              | 2 +-
src/remote/remote_daemon_dispatch.c | 2 +-
src/remote/remote_driver.c          | 4 ++--
src/remote/remote_protocol.x        | 2 +-
src/remote_protocol-structs         | 2 +-
src/rpc/gendispatch.pl              | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux