>-----Original Message----- >From: Peter Krempa <pkrempa@xxxxxxxxxx> >Subject: Re: [PATCH v2 03/21] qemu: Add TDX capability > >On Fri, Jun 27, 2025 at 07:42:48 +0000, Duan, Zhenzhong wrote: >> >> >> >-----Original Message----- >> >From: Peter Krempa <pkrempa@xxxxxxxxxx> >> >Subject: Re: [PATCH v2 03/21] qemu: Add TDX capability >> > >> >On Wed, Jun 25, 2025 at 13:19:34 +0200, Peter Krempa via Devel wrote: >> >> On Wed, Jun 25, 2025 at 17:45:15 +0800, Zhenzhong Duan wrote: >> >> > QEMU_CAPS_TDX_GUEST set means TDX supported with this QEMU. >> >> > >> >> > Signed-off-by: Chenyi Qiang <chenyi.qiang@xxxxxxxxx> >> >> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxx> >> >> > Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> >> >> > --- >> >> > src/qemu/qemu_capabilities.c | 2 ++ >> >> > src/qemu/qemu_capabilities.h | 1 + >> >> > 2 files changed, 3 insertions(+) >> >> >> >> I presume that this is not yet supported by qemu since a qemu dump >> >> showing this capability is missing. >> >> >> >> Once there will be a released or in development qemu version that >> >> supports this please add a capability dump ( see >> >> tests/qemucapabilitiesdata/README.rst ) with the 'tdx' variant. A >> >> variant is needed because I don't have hardware supporting tdx so I >> >> can't be updating those on the main variant. >> > >> >I noticed that you did add a dump later on, any reason why it's not >> >added before this patch so that this patch will show that the detection >> >works? >> >> I don't understand this rule. For example, in linux kernel patchset, selftests >> are always at the end of the whole series. >> >> Adding dump for a feature before the commit introducing the feature will >> make the 'ninja test' fail on the commit adding the dump. > >Well, it will not fail if the output files match the state without the >feature. The patch adding the capability will then also need to include >changes to the output files to correspond with the feature now existing. Get your point, that does make sense. Will do. > >>Don't we need to >> ensure each commit having 'ninja test' succeed? > >Yes all tests must pass after each commit. > >> About your suggestion, do you mean moving both qemucapabilitiestest and >> qemuxmlconftest dumps(patch18-20) before this patch? Or only >patch18-19? > >The important part is that we do have tests for this. Thus I will not >require that you move the tests. > >Usually we include capability dumps early, so that the patches adding >the flags show which capability dumps enable the new flags. This would >mean moving patches 18 and 19 earlier. Thus if you're okay with fixing >the two instances of test output file changes that will be necessary >that is also an option. Will do. Thanks Zhenzhong > >The patch adding domain XML tests needs to be still kept at the end.
