Re: [PATCH v2 12/13] qemuxmlconftest: Prepare for proper testing in 'disk-cdrom-usb-empty'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 23, 2025 at 21:59:17 +0200, Peter Krempa wrote:
> From: Peter Krempa <pkrempa@xxxxxxxxxx>
> 
> Modify the validation of empty cdroms to trigger only for
> VIR_DOMAIN_DISK_MODEL_USB_STORAGE as with 'usb-bot' we can properly
> emulate a cdrom.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/qemu/qemu_validate.c                      |  3 +-
>  ...om-usb-empty.x86_64-latest.abi-update.args | 33 ++++++++++++++++
>  ...rom-usb-empty.x86_64-latest.abi-update.xml | 38 +++++++++++++++++++
>  tests/qemuxmlconftest.c                       |  1 +
>  4 files changed, 74 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxmlconfdata/disk-cdrom-usb-empty.x86_64-latest.abi-update.args
>  create mode 100644 tests/qemuxmlconfdata/disk-cdrom-usb-empty.x86_64-latest.abi-update.xml

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux