Re: [libvirt PATCH v2 7/7] qemu: format pt and xstup on the command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 18, 2025 at 12:46:23 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko <jtomko@xxxxxxxxxx>
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  src/qemu/qemu_command.c                            | 2 ++
>  tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 6fae9b1f5a..b752a828ba 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -6227,6 +6227,8 @@ qemuBuildIOMMUCommandLine(virCommand *cmd,
>                                    "s:driver", "amd-iommu",
>                                    "s:pci-id", iommu->info.alias,
>                                    "S:intremap", qemuOnOffAuto(iommu->intremap),
> +                                  "T:pt", iommu->pt,
> +                                  "T:xtsup", iommu->xtsup,
>                                    "T:device-iotlb", iommu->iotlb,
>                                    NULL) < 0)
>              return -1;
> diff --git a/tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args b/tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args
> index 36244edb3a..20d7e379e6 100644
> --- a/tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args
> +++ b/tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args
> @@ -27,7 +27,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \
>  -no-shutdown \
>  -boot strict=on \
>  -device '{"driver":"AMDVI-PCI","id":"iommu0","bus":"pcie.0","addr":"0x1"}' \
> --device '{"driver":"amd-iommu","pci-id":"iommu0","intremap":"on","device-iotlb":true}' \
> +-device '{"driver":"amd-iommu","pci-id":"iommu0","intremap":"on","pt":true,"xtsup":true,"device-iotlb":true}' \
>  -audiodev '{"id":"audio1","driver":"none"}' \
>  -global ICH9-LPC.noreboot=off \
>  -watchdog-action reset \

I wouldn't mind if this were squashed to 5/7, but regardless:

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux