Re: [libvirt PATCH] qemu: forbid readonly attribute for externally launched virtiofsd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 19, 2025 at 06:22:44PM +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko <jtomko@xxxxxxxxxx>
> 
> In that case, libvirtd cannot set it on the command line because
> virtiofsd is not launched by libvirt.
> 
> https://issues.redhat.com/browse/RHEL-87522
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  src/qemu/qemu_validate.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
> index 87588024ce..013ff14d75 100644
> --- a/src/qemu/qemu_validate.c
> +++ b/src/qemu/qemu_validate.c
> @@ -4684,6 +4684,11 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs,
>                                 _("virtiofs does not support wrpolicy"));
>                  return -1;
>              }
> +            if (fs->readonly) {
> +                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> +                               _("readonly mode cannot be set for extrenally started virtiofsd"));

s/extrenally/externally/

> +                return -1;
> +            }
>          }

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux