On Wed, May 14, 2025 at 16:24:12 +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik <mprivozn@xxxxxxxxxx>
>
> The qemuDomainHasHotpluggableStartupVcpus() function is declared
> to return an int but in fact its return type is a boolean. Even
> its only caller (qemuProcessLaunch()) threads its retval as a
s/threads/treats/
> boolean. Switch the return type from integer to boolean.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> src/qemu/qemu_process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 1af91c5909..7fe49adfb4 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -6405,7 +6405,7 @@ qemuProcessValidateHotpluggableVcpus(virDomainDef *def)
> }
>
>
> -static int
> +static bool
> qemuDomainHasHotpluggableStartupVcpus(virDomainDef *def)
> {
> size_t maxvcpus = virDomainDefGetVcpusMax(def);
> --
> 2.49.0
>
Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
