On Wed, May 14, 2025 at 11:24:22AM +0800, yong.huang@xxxxxxxxxx wrote:
> From: Hyman Huang <yong.huang@xxxxxxxxxx>
>
> As advised by the GNU TLS, the caller should attempt again
> if the gnutls_record_{recv,send} return EAGAIN or EINTR;
> check the following link to view the details:
> https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html
>
> virNetClientSetTLSSession failed to handle EINTR/EGAIN,
> though EGAIN seems like it ought to be unlikely given that
> the caller waited for G_IO_IN.
>
> Add the {repoll, retry} logic to handle EINTR/EGAIN that
> may happen theoretically. This may reduce the likelihood
> that the upper application receives the following error
> message utmostly when it calls the virConnectOpenAuth API:
> Unable to read TLS confirmation: Resource temporarily unavailable
>
> Note that in order to fully avoid the mentioned problem, the
> upper application should retry virConnectOpenAuth.
The patch is fine but this needs your Signed-off-by line
to state that you're contributing according to
https://developercertificate.org/
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
