Re: [PATCH 1/1] virsh: Add option '--no-pkttyagent'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for your review and comments!

On 2025-05-06  10:24, Peter Krempa wrote:

> As witnessed by the fact that you needed to include assert.h we don't
> use asserts in the code base.
> 
> While this code path should not be possible to reach without doing
> a programming error we still should report an error using vshError as
> in all other cases.

Do I need to worry about (needless) translation effort of that error
message?  Or should I just use a generic one like

  vshError(ctl, "%s", _("unknown error"));

or, more specific, but probably less accurate,

  vshError(ctl, "%s", _("unknown option"));

already used elsewhere in the code?



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux