On Sun, Apr 27, 2025 at 19:48:04 +0800, honglei.wang@xxxxxxxxxx wrote:
> From: ray <honglei.wang@xxxxxxxxxx>
>
> Signed-off-by: ray <honglei.wang@xxxxxxxxxx>
> ---
Generally patches adding a capability flag should only add the
capability flag. Thus you'll need to split this patch.
1) capability addition
- move it ahead to the beginning of the series (doing that will
allow you to do capability checks when adding the code instead
when adding the capability
- note the full flag name (QEMU_CAPS...) in the summary line of the
commit message
2) domain caps addition
- that ought to be done after the code addition is compelete, thus
after you add the XML schema bits and implementation
> src/qemu/qemu_capabilities.c | 5 +++++
> src/qemu/qemu_capabilities.h | 1 +
> src/qemu/qemu_validate.c | 6 ++++++
> tests/domaincapsdata/qemu_10.0.0-q35.x86_64+amdsev.xml | 1 +
> tests/domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 1 +
> tests/domaincapsdata/qemu_10.0.0-tcg.x86_64+amdsev.xml | 1 +
> tests/domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 1 +
> tests/domaincapsdata/qemu_10.0.0.s390x.xml | 1 +
> tests/domaincapsdata/qemu_10.0.0.x86_64+amdsev.xml | 1 +
> tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 1 +
> tests/domaincapsdata/qemu_4.2.0-virt.aarch64.xml | 1 +
> tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 +
> tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 +
> tests/domaincapsdata/qemu_5.0.0-tcg-virt.riscv64.xml | 1 +
> tests/domaincapsdata/qemu_5.0.0-virt.aarch64.xml | 1 +
> tests/domaincapsdata/qemu_5.0.0-virt.riscv64.xml | 1 +
> tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 +
> tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 +
> tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 +
All of the above is suspicious. The test files were forgotten after we
dropped support for the qemu versions mentioned in them. How did you
modify these?
Interestingly there are more of the files for unsupported versions but
you didnt modify all of them.
Anyways I'll send a patch deleting those.
The rest of the patch looks good but most of the code additions will
need to be moved to corresponding patches.
