Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Typo in subject, make it "deprecate".

Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx> writes:

> For change, pause, resume, complete, dismiss and finalize actions
> corresponding job- and block-job commands are almost equal. The
> difference is in find_block_job_locked() vs find_job_locked()
> functions. What's different?
>
> 1. find_block_job_locked() do check, is found job a block-job. This OK
>    when moving to more generic API, no needs to document this change.
>
> 2. find_block_job_locked() reports DeviceNotActive on failure, when
>    find_job_locked() reports GenericError. So, lets document this
>    difference in deprecated.txt. Still, for dismiss and finalize errors
>    are not documented at all, so be silent in deprecated.txt as well.
>
> ACKed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxxx>

Reviewed-by: Markus Armbruster <armbru@xxxxxxxxxx>



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux