Re: [PATCH] virDomainDiskDefValidateSourceChainOne: Fix validation of 'data-file' nesting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 28, 2025 at 10:09:17 +0100, Peter Krempa wrote:
> From: Peter Krempa <pkrempa@xxxxxxxxxx>
> 
> As the 'dataStore' is internally represented as a virStorageSource
> object it has provisions for nesting which is not supported.
> 
> When I've reviewed and modified the commit adding data file parsing
> support I've added code that was supposed to reject any 'backingStore'
> and 'dataStore' structures nested in a source of a 'dataStore'.
> 
> Unfortunately the check was broken as one of the terms checked the
> presence of parent's 'backingStore' instead of the nesting.
> 
> Fix it and add tests.
> 
> Fixes: b3171cf8da3
> Resolves: https://issues.redhat.com/browse/RHEL-85320
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/conf/domain_validate.c                    |  2 +-
>  ...sk-qcow2-datafile-store.x86_64-latest.args | 43 +++++++++++--------
>  ...isk-qcow2-datafile-store.x86_64-latest.xml | 22 +++++++++-
>  .../disk-qcow2-datafile-store.xml             | 19 ++++++++
>  4 files changed, 66 insertions(+), 20 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux